pgsql: Use "ssize_t" not "long" in max_stack_depth-related code.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Use "ssize_t" not "long" in max_stack_depth-related code.
Date: 2025-01-30 21:44:53
Message-ID: E1tdcLF-004Uld-3Z@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Use "ssize_t" not "long" in max_stack_depth-related code.

This change adapts these functions to the machine's address width
without depending on "long" to be the right size. (It isn't on
Win64, for example.) While it seems unlikely anyone would care
to run with a stack depth limit exceeding 2GB, this is part of a
general push to avoid using type "long" to represent memory sizes.

It's convenient to use ssize_t rather than the perhaps-more-obvious
choice of size_t/Size, because the code involved depends on working
with a signed data type. Our MAX_KILOBYTES limit already ensures
that ssize_t will be sufficient to represent the maximum value of
max_stack_depth.

Extracted from a larger patch by Vladlen, plus additional hackery
by me.

Author: Vladlen Popolitov <v(dot)popolitov(at)postgrespro(dot)ru>
Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/1a01f0-66ec2d80-3b-68487680@27595217

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b9d232b9de89aa9282f9a2e7c85f783bcd334af2

Modified Files
--------------
src/backend/utils/misc/guc.c | 6 +++---
src/backend/utils/misc/stack_depth.c | 30 +++++++++++++++++-------------
src/include/miscadmin.h | 4 ++--
3 files changed, 22 insertions(+), 18 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2025-01-31 02:06:51 pgsql: Fix comment of StrategySyncStart()
Previous Message Tom Lane 2025-01-30 20:36:54 pgsql: Avoid integer overflow while testing wal_skip_threshold conditio