| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Move BitmapTableScan per-scan setup into a helper |
| Date: | 2025-01-30 20:29:47 |
| Message-ID: | E1tdbAZ-004U9U-Jo@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Move BitmapTableScan per-scan setup into a helper
Add BitmapTableScanSetup(), a helper which contains all of the code that
must be done on every scan of the table in a bitmap table scan. This
includes scanning the index, building the bitmap, and setting up the
scan descriptors.
Pushing this setup into a helper function makes BitmapHeapNext() more
readable.
Reviewed-by: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAN55FZ1vXu%2BZdT0_MM-i1vbTdfHHf0KR3cK6R5gs6dNNNpyrJw%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a5358c14b2fe2210a1ac0b836f8d54723043fba2
Modified Files
--------------
src/backend/executor/nodeBitmapHeapscan.c | 206 ++++++++++++++++--------------
1 file changed, 107 insertions(+), 99 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-01-30 20:36:37 | pgsql: Avoid integer overflow while testing wal_skip_threshold conditio |
| Previous Message | Tom Lane | 2025-01-30 18:21:50 | pgsql: Simplify executor's handling of CaseTestExpr & CoerceToDomainVal |