| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: pg_amcheck: Fix test failure on Windows with non-existing role |
| Date: | 2025-01-26 23:10:13 |
| Message-ID: | E1tcBld-003jyN-9F@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
pg_amcheck: Fix test failure on Windows with non-existing role
For SSPI auth extra users need to be explicitly allowed, or we get
"SSPI authentication failed" instead of the expected "role does not
exist" error.
This report also means that the test has never worked on Windows since
its introduction in 9706092839db, because it has always bumped on an
authentication failure rather than an error about the role not existing.
Oversight in eef4a33f62f7, that has added a pattern check on the error
generated by the command.
Per report from Tom Lane, via buildfarm member drongo.
Author: Dagfinn Ilmari Mannsåker
Reviewed-by: Andrew Dunstan
Discussion: https://postgr.es/m/379085.1737734611@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/14793f47192b5eb02197cd03afb88559d7514b76
Modified Files
--------------
src/bin/pg_amcheck/t/002_nonesuch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-01-27 04:52:34 | pgsql: Print out error position for some ALTER TABLE ALTER COLUMN type |
| Previous Message | Noah Misch | 2025-01-26 17:43:52 | pgsql: Test postmaster with program_options_handling_ok() et al. |