From: | Noah Misch <noah(at)leadboat(dot)com> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: At update of non-LP_NORMAL TID, fail instead of corrupting page |
Date: | 2025-01-25 19:29:54 |
Message-ID: | E1tblqs-003VLn-18@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
At update of non-LP_NORMAL TID, fail instead of corrupting page header.
The right mix of DDL and VACUUM could corrupt a catalog page header such
that PageIsVerified() durably fails, requiring a restore from backup.
This affects only catalogs that both have a syscache and have DDL code
that uses syscache tuples to construct updates. One of the test
permutations shows a variant not yet fixed.
This makes !TransactionIdIsValid(TM_FailureData.xmax) possible with
TM_Deleted. I think core and PGXN are indifferent to that.
Per bug #17821 from Alexander Lakhin. Back-patch to v13 (all supported
versions). The test case is v17+, since it uses INJECTION_POINT.
Discussion: https://postgr.es/m/17821-dd8c334263399284@postgresql.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d28cd3e7b21c41a710fd9c188a57dad99f28805f
Modified Files
--------------
src/backend/access/heap/heapam.c | 49 +++++-
src/backend/utils/cache/inval.c | 3 +
src/include/access/tableam.h | 3 +-
src/test/modules/injection_points/Makefile | 5 +-
.../expected/syscache-update-pruned.out | 87 ++++++++++
.../expected/syscache-update-pruned_1.out | 86 ++++++++++
.../injection_points/injection_points--1.0.sql | 8 +
src/test/modules/injection_points/meson.build | 4 +-
.../modules/injection_points/regress_injection.c | 71 ++++++++
.../specs/syscache-update-pruned.spec | 179 +++++++++++++++++++++
10 files changed, 490 insertions(+), 5 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Álvaro Herrera | 2025-01-26 16:38:19 | pgsql: Add missing CommandCounterIncrement |
Previous Message | Tom Lane | 2025-01-25 17:42:49 | pgsql: Doc: recommend "psql -X" for restoring pg_dump scripts. |