pgsql: Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull

From: Noah Misch <noah(at)leadboat(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull
Date: 2025-01-25 19:29:54
Message-ID: E1tblqr-003VLg-Vo@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Test ECPG decadd(), decdiv(), decmul(), and decsub() for risnull() input.

Since commit 757fb0e5a9a61ac8d3a67e334faeea6dc0084b3f, these
Informix-compat functions return 0 without changing the output
parameter. Initialize the output parameter before the test call, making
that obvious. Before this, the expected test output has been depending
on freed stack memory. "gcc -ftrivial-auto-var-init=pattern" revealed
that. Back-patch to v13 (all supported versions).

Discussion: https://postgr.es/m/20250106192748.cf.nmisch@google.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7819a25cd101b574f5422edb00fe3376fbb646da

Modified Files
--------------
.../ecpg/test/compat_informix/dec_test.pgc | 10 +
.../ecpg/test/expected/compat_informix-dec_test.c | 10 +
.../test/expected/compat_informix-dec_test.stdout | 232 ++++++++++-----------
3 files changed, 136 insertions(+), 116 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Álvaro Herrera 2025-01-26 16:38:19 pgsql: Add missing CommandCounterIncrement
Previous Message Tom Lane 2025-01-25 17:42:49 pgsql: Doc: recommend "psql -X" for restoring pg_dump scripts.