pgsql: Use the correct sizeof() in BufFileLoadBuffer

From: Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Use the correct sizeof() in BufFileLoadBuffer
Date: 2025-01-25 01:17:44
Message-ID: E1tbUnw-003MGe-OX@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Use the correct sizeof() in BufFileLoadBuffer

The sizeof() call should reference buffer.data, because that's the
buffer we're reading data into, not the whole PGAlignedBuffer union.
This was introduced by 44cac93464, which replaced the simple buffer
with a PGAlignedBuffer field.

It's benign, because the buffer is the largest field of the union, so
the sizes are the same. But it's easy to trip over this in a patch, so
fix and backpatch. Commit 44cac93464 went into 12, but that's EOL.

Backpatch-through: 13
Discussion: https://postgr.es/m/928bdab1-6567-449f-98c4-339cd2203b87@vondra.me

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8cedf6a1b9fcbd33f97413b6a37b38d936522624

Modified Files
--------------
src/backend/storage/file/buffile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tomas Vondra 2025-01-25 01:17:53 pgsql: Use the correct sizeof() in BufFileLoadBuffer
Previous Message Tomas Vondra 2025-01-25 01:17:36 pgsql: Use the correct sizeof() in BufFileLoadBuffer