From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Reverse the search order in afterTriggerAddEvent(). |
Date: | 2025-01-23 16:08:12 |
Message-ID: | E1tazka-0037EW-1d@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Reverse the search order in afterTriggerAddEvent().
When scanning existing AfterTriggerSharedData records in search
of a match to the event being queued, we were examining the
records from oldest to newest. But it makes more sense to do
the opposite. The newest record is likely to be from the current
query, while the oldest is likely to be from some previous command
in the same transaction, which will likely have different details.
There aren't expected to be very many active AfterTriggerSharedData
records at once, so that this change is unlikely to make any
spectacular difference. Still, having added a nontrivially-expensive
bms_equal call to this loop yesterday, I feel a need to shave cycles
where possible.
Discussion: https://postgr.es/m/4166712.1737583961@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7921927bbb9d4a80ced9283b27c26eedb638f555
Modified Files
--------------
src/backend/commands/trigger.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Davis | 2025-01-23 17:10:58 | pgsql: Add support for Unicode case folding. |
Previous Message | Álvaro Herrera | 2025-01-23 14:59:38 | pgsql: Allow NOT VALID foreign key constraints on partitioned tables |