pgsql: Rework handling of pending data for backend statistics

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Rework handling of pending data for backend statistics
Date: 2025-01-21 02:31:41
Message-ID: E1ta43J-002edn-Kf@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Rework handling of pending data for backend statistics

9aea73fc61d4 has added support for backend statistics, relying on
PgStat_EntryRef->pending for its data pending for flush. This design
lacks in flexibility, because the pending list does some memory
allocation, making it unsuitable if incrementing counters in critical
sections.

Pending data of backend statistics is reworked so the implementation
does not depend on PgStat_EntryRef->pending anymore, relying on a static
area of memory to store the counters that are flushed when stats are
reported to the pgstats dshash. An advantage of this approach is to
allow the pending data to be manipulated in critical sections; some
patches are under discussion and require that.

The pending data is tracked by PendingBackendStats, local to
pgstat_backend.c. Two routines are introduced to allow IO statistics to
update the backend-side counters. have_static_pending_cb and
flush_static_cb are used for the flush, instead of flush_pending_cb.

Author: Bertrand Drouvot, Michael Paquier
Discussion: https://postgr.es/m/66efowskppsns35v5u2m7k4sdnl7yoz5bo64tdjwq7r5lhplrz@y7dme5xwh2r5

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4feba03d8b925c4cdda460927611d6b17fb01803

Modified Files
--------------
src/backend/utils/activity/pgstat.c | 4 +-
src/backend/utils/activity/pgstat_backend.c | 140 ++++++++++++++++++---------
src/backend/utils/activity/pgstat_io.c | 23 ++---
src/backend/utils/activity/pgstat_relation.c | 4 +-
src/include/pgstat.h | 9 ++
src/include/utils/pgstat_internal.h | 9 +-
6 files changed, 116 insertions(+), 73 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Langote 2025-01-21 03:53:56 pgsql: Refactor ExecScan() to allow inlining of its core logic
Previous Message Michael Paquier 2025-01-21 01:13:36 pgsql: Rename some pgstats callbacks related to flush of entries