| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Don't hard-code the input file name in gen_tabcomplete.pl's outp |
| Date: | 2024-10-10 21:02:17 |
| Message-ID: | E1sz0Ib-000EEv-Gh@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Don't hard-code the input file name in gen_tabcomplete.pl's output.
Use $ARGV[0], that is the specified input file name, in #line
directives generated by gen_tabcomplete.pl. This makes code
coverage reports work properly in the meson build system (where
the input file name will be a relative path).
Also fix up brain fade in the meson build rule for tab-complete.c:
we only need to write the input file name once not twice.
Jacob Champion (some cosmetic adjustments by me)
Discussion: https://postgr.es/m/CAOYmi+=+oWAoi8pqnH0MJQqsSn4ddzqDhqRQJvyiN2aJSWvw2w@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c75c6f8d280a3364643fc51f9c9fdf2dee0213c2
Modified Files
--------------
src/bin/psql/gen_tabcomplete.pl | 17 +++++++++--------
src/bin/psql/meson.build | 4 ++--
2 files changed, 11 insertions(+), 10 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2024-10-11 00:58:26 | Re: pgsql: Doc: add check to detect non-breaking spaces in the docs. |
| Previous Message | Robert Haas | 2024-10-10 17:45:58 | Re: pgsql: Doc: add check to detect non-breaking spaces in the docs. |