pgsql: Apply GUC name from central table in more places of guc.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Apply GUC name from central table in more places of guc.c
Date: 2024-10-09 09:53:44
Message-ID: E1syTO5-0000sM-9K@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Apply GUC name from central table in more places of guc.c

The name extracted from the record of the GUC tables is applied to more
internal places of guc.c. This change has the advantage to simplify
parse_and_validate_value(), where the "name" was only used in elog
messages, while it was required to match with the name from the GUC
record.

pg_parameter_aclcheck() now passes the name of the GUC from its record
in two places rather than the caller's argument. The value given to
this function goes through convert_GUC_name_for_parameter_acl() that
does a simple ASCII downcasing.

Few GUCs mix character casing in core; one test is added for one of
these code paths with "IntervalStyle".

Author: Peter Smith, Michael Paquier
Discussion: https://postgr.es/m/ZwNh4vkc2NHJHnND@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f3f06b13308e3c250bb8b0afee861744cda06cf6

Modified Files
--------------
src/backend/utils/misc/guc.c | 65 +++++++++++++++++++--------------------
src/test/regress/expected/guc.out | 4 +++
src/test/regress/sql/guc.sql | 3 ++
3 files changed, 39 insertions(+), 33 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2024-10-09 21:08:00 pgsql: Avoid crash in estimate_array_length with null root pointer.
Previous Message Richard Guo 2024-10-09 08:22:36 pgsql: Consider explicit incremental sort for mergejoins