From: | Robert Haas <rhaas(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: File size in a backup manifest should use uint64, not size_t. |
Date: | 2024-10-02 14:09:24 |
Message-ID: | E1sw02e-001rfO-2f@gemulon.postgresql.org |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
File size in a backup manifest should use uint64, not size_t.
size_t is the size of an object in memory, not the size of a file on disk.
Thanks to Tom Lane for noting the error.
Discussion: http://postgr.es/m/1865585.1727803933@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d94cf5ca7fad9cd81af5eac491bfbaf0facb9f6f
Modified Files
--------------
src/bin/pg_combinebackup/load_manifest.c | 4 ++--
src/bin/pg_combinebackup/load_manifest.h | 2 +-
src/bin/pg_combinebackup/write_manifest.c | 5 +++--
src/bin/pg_combinebackup/write_manifest.h | 2 +-
src/bin/pg_verifybackup/astreamer_verify.c | 13 ++++++++-----
src/bin/pg_verifybackup/pg_verifybackup.c | 16 +++++++++-------
src/bin/pg_verifybackup/pg_verifybackup.h | 2 +-
src/common/parse_manifest.c | 4 ++--
src/include/common/parse_manifest.h | 2 +-
9 files changed, 28 insertions(+), 22 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2024-10-02 21:30:52 | pgsql: Parse libpq's "keepalives" option more like other integer option |
Previous Message | Daniel Gustafsson | 2024-10-02 12:55:38 | pgsql: doc: Missing markup, punctuation and wordsmithing |