pgsql: Refactor tidstore.c iterator buffering.

From: Thomas Munro <tmunro(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Refactor tidstore.c iterator buffering.
Date: 2024-07-24 05:33:39
Message-ID: E1sWUd9-000wsz-NC@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Refactor tidstore.c iterator buffering.

Previously, TidStoreIterateNext() would expand the set of offsets for
each block into an internal buffer that it overwrote each time. In
order to be able to collect the offsets for multiple blocks before
working with them, change the contract. Now, the offsets are obtained
by a separate call to TidStoreGetBlockOffsets(), which can be called at
a later time. TidStoreIteratorResult objects are safe to copy and store
in a queue.

Reviewed-by: Noah Misch <noah(at)leadboat(dot)com>
Discussion: https://postgr.es/m/CAAKRu_bbkmwAzSBgnezancgJeXrQZXy4G4kBTd+5=cr86H5yew@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f6bef362cac8c47137f9786171eaee5a95fb538b

Modified Files
--------------
src/backend/access/common/tidstore.c | 63 ++++++++++++--------------
src/backend/access/heap/vacuumlazy.c | 9 +++-
src/include/access/tidstore.h | 12 +++--
src/test/modules/test_tidstore/test_tidstore.c | 9 +++-
4 files changed, 51 insertions(+), 42 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2024-07-24 09:01:14 pgsql: Doc: Fix the mistakes in the subscription's failover option.
Previous Message Amit Kapila 2024-07-24 04:54:40 pgsql: Allow altering of two_phase option of a SUBSCRIPTION.