| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Move extern declarations for EXEC_BACKEND to header files |
| Date: | 2024-07-23 13:15:02 |
| Message-ID: | E1sWFM6-000r2T-S0@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Move extern declarations for EXEC_BACKEND to header files
This fixes warnings from -Wmissing-variable-declarations (not yet part
of the standard warning options) under EXEC_BACKEND. The
NON_EXEC_STATIC variables need a suitable declaration in a header file
under EXEC_BACKEND.
Also fix the inconsistent application of the volatile qualifier for
PMSignalState, which was revealed by this change.
Reviewed-by: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://www.postgresql.org/message-id/flat/e0a62134-83da-4ba4-8cdb-ceb0111c95ce(at)eisentraut(dot)org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d3cc5ffe81f64c6418ba9b18a9db32392f8027e6
Modified Files
--------------
src/backend/postmaster/launch_backend.c | 12 +-----------
src/include/postmaster/postmaster.h | 4 ++++
src/include/postmaster/syslogger.h | 4 ++++
src/include/storage/pmsignal.h | 4 ++++
src/include/storage/proc.h | 5 +++++
5 files changed, 18 insertions(+), 11 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-07-24 03:02:33 | pgsql: Detect integer overflow in array_set_slice(). |
| Previous Message | Noah Misch | 2024-07-23 12:32:42 | pgsql: Fix private struct field name to match the code using it. |