pgsql: Revert "Test that vacuum removes tuples older than OldestXmin"

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Revert "Test that vacuum removes tuples older than OldestXmin"
Date: 2024-07-22 21:01:53
Message-ID: E1sW0AL-000lJ2-Gj@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Revert "Test that vacuum removes tuples older than OldestXmin"

This reverts commit aa607980aee08416211f003ab41aa750f5559712.

This test proved to be unstable on the buildfarm, timing out before the
standby could catch up on 32-bit machines where more rows were required
and failing to reliably trigger multiple index vacuum rounds on 64-bit
machines where fewer rows should be required.

Because the instability is only known to be present on versions of
Postgres with TIDStore used for dead TID storage by vacuum, this is only
being reverted on master and REL_17_STABLE.

As having this coverage may be valuable, there is a discussion on the
thread of possible ways to stabilize the test. If that happens, a fixed
test can be committed again.

Backpatch-through: 17
Reported-by: Tom Lane

Discussion: https://postgr.es/m/614152.1721580711%40sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/efcbb76efe406d59c2ba8b4a09e04c01158ba575

Modified Files
--------------
src/test/recovery/meson.build | 1 -
src/test/recovery/t/043_vacuum_horizon_floor.pl | 268 ------------------------
2 files changed, 269 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2024-07-22 23:44:48 pgsql: Doc: improve description of plpgsql's FETCH and MOVE commands.
Previous Message Robert Haas 2024-07-22 19:42:46 pgsql: Initialize wal_level in the initial checkpoint record.