| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix new assertion for MERGE view_name ... DO NOTHING. |
| Date: | 2024-07-13 15:11:06 |
| Message-ID: | E1sSeOw-001Vz4-1h@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix new assertion for MERGE view_name ... DO NOTHING.
Such queries don't expand automatically updatable views, and ModifyTable
uses the wholerow attribute unconditionally. The user-visible behavior
is fine, so change to more-specific assertions. Commit
d5f788b41dc2cbdde6e7694c70dda54d829a5ed5 added the wrong assertion.
Back-patch to v17, where commit 5f2e179bd31e5f5803005101eb12a8d7bf8db8f3
introduced MERGE view_name.
Reported by Alexander Lakhin.
Discussion: https://postgr.es/m/e4b40a88-c134-6926-3196-bc4501cb87a2@gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d5e6891502ca9e359aa5f5a381d904fe9d606338
Modified Files
--------------
src/backend/executor/nodeModifyTable.c | 40 +++++++++++++++------------
src/test/regress/expected/updatable_views.out | 5 ++++
src/test/regress/sql/updatable_views.sql | 5 ++++
3 files changed, 33 insertions(+), 17 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2024-07-13 20:24:06 | pgsql: Use correct collate.windows.win1252.out |
| Previous Message | Andrew Dunstan | 2024-07-13 12:15:11 | pgsql: Make sure to run pg_isready on correct port |