| From: | Amit Kapila <akapila(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: To improve the code, move the error check in logical_read_xlog_p |
| Date: | 2024-07-09 03:45:49 |
| Message-ID: | E1sR1nZ-000w7b-0k@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
To improve the code, move the error check in logical_read_xlog_page().
Commit 0fdab27ad6 changed the code to wait for WAL to be available before
determining the timeline but forgot to move the failure check.
This change is to make the related code easier to understand and enhance
otherwise there is no bug in the current code.
In the passing, improve the nearby comments to explain why we determine
am_cascading_walsender after waiting for the required WAL.
Author: Peter Smith
Reviewed-by: Bertrand Drouvot, Amit Kapila
Discussion: https://postgr.es/m/CAHut+PvqX49fusLyXspV1Mmd_EekPtXG0oT146vZjcb9XDvNgw@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/571f7f70865cdaf1a49e7934208ad139575e3f03
Modified Files
--------------
src/backend/replication/walsender.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2024-07-09 07:18:43 | pgsql: SQL/JSON: Various improvements to SQL/JSON query function docs |
| Previous Message | Michael Paquier | 2024-07-09 01:28:08 | pgsql: Use pgstat_kind_infos to write fixed shared statistics |