| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Cope with inplace update making catcache stale during TOAST fetc |
| Date: | 2024-06-28 02:26:55 |
| Message-ID: | E1sN1KA-003J0G-5r@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Cope with inplace update making catcache stale during TOAST fetch.
This extends ad98fb14226ae6456fbaed7990ee7591cbe5efd2 to invals of
inplace updates. Trouble requires an inplace update of a catalog having
a TOAST table, so only pg_database was at risk. (The other catalog on
which core code performs inplace updates, pg_class, has no TOAST table.)
Trouble would require something like the inplace-inval.spec test.
Consider GRANT ... ON DATABASE fetching a stale row from cache and
discarding a datfrozenxid update that vac_truncate_clog() has already
relied upon. Back-patch to v12 (all supported versions).
Reviewed (in an earlier version) by Robert Haas.
Discussion: https://postgr.es/m/20240114201411.d0@rfd.leadboat.com
Discussion: https://postgr.es/m/20240512232923.aa.nmisch@google.com
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/af73e37fa181283a3199cda2233d89c7a669f772
Modified Files
--------------
src/backend/catalog/catalog.c | 21 ++++++++++++++++++
src/backend/utils/cache/catcache.c | 44 +++++++++++++++++++++++++++++++++++---
src/include/catalog/catalog.h | 2 ++
3 files changed, 64 insertions(+), 3 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-06-28 03:33:11 | pgsql: Improve locking around InjectionPointRun() |
| Previous Message | Noah Misch | 2024-06-28 02:26:54 | pgsql: Lock owned sequences during ALTER TABLE SET { LOGGED | UNLOGGED |