pgsql: Fix generate_union_paths for non-sortable types.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix generate_union_paths for non-sortable types.
Date: 2024-05-21 17:03:22
Message-ID: E1s9StW-001ES0-II@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix generate_union_paths for non-sortable types.

The previous logic would fail to set groupList when
grouping_is_sortable() returned false, which could cause queries
to return wrong answers when some columns were not sortable.

David Rowley, reviewed by Heikki Linnakangas and Álvaro Herrera.
Reported by Hubert "depesz" Lubaczewski.

Discussion: http://postgr.es/m/Zktzf926vslR35Fv@depesz.com
Discussion: http://postgr.es/m/CAApHDvra=c8_zZT0J-TftByWN2Y+OJfnjNJFg4Dfdi2s+QzmqA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c37267162e889fe783786b9e28d1b65b82365a00

Modified Files
--------------
src/backend/optimizer/prep/prepunion.c | 21 ++++++++++++---------
src/test/regress/expected/union.out | 13 +++++++++++++
src/test/regress/sql/union.sql | 6 ++++++
3 files changed, 31 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message noreply 2024-05-22 20:36:50 pgsql: Tag refs/tags/REL_17_BETA1 was created
Previous Message Tom Lane 2024-05-20 21:44:00 pgsql: Stamp 17beta1.