pgsql: Fix libpq_encryption tests when compiled without SSL support

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix libpq_encryption tests when compiled without SSL support
Date: 2024-04-12 16:56:26
Message-ID: E1rvKCQ-001lVR-6D@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix libpq_encryption tests when compiled without SSL support

It correctly skipped tests involving SSL in the server when SSL
support was not compiled in, but even when SSL is not enabled in the
server and the connection is established without SSL, libpq behaves
differently in many of the test scenarios when libpq is compiled
without SSL support. For example, with sslmode=prefer, if libpq is
compiled with SSL support it will attempt to use SSL, but without SSL
support it will try authenticating in plaintext mode directly. The
expected test output didn't take that into account.

Discussion: https://www.postgresql.org/message-id/CA%2BhUKG%2BHRTtB%2Bx%2BKKKj_cfX6sNhbeGuqmGxjGMwdVPG7YGFP8w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0a5f2291891ffca96ccd3ef29c9c1541a9277970

Modified Files
--------------
.../libpq_encryption/t/001_negotiate_encryption.pl | 104 ++++++++++++++-------
1 file changed, 71 insertions(+), 33 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2024-04-12 16:57:02 Re: pgsql: Refactor libpq state machine for negotiating encryption
Previous Message Andrew Dunstan 2024-04-12 14:59:20 pgsql: Fix some memory leaks associated with parsing json and manifests