| From: | Amit Langote <amitlan(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Code review for 6190d828cd2 |
| Date: | 2024-03-25 10:45:43 |
| Message-ID: | E1rohpm-005Yq0-QE@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Code review for 6190d828cd2
* Fix the comment of init_dummy_sjinfo() to remove references to
non-existing parameters 'rel1' and 'rel2'.
* Adjust consider_new_or_clause() to call init_dummy_sjinfo() to make
up a SpecialJoinInfo for inner joins like other code sites that
were adjusted in 6190d828cd2 to do so.
Author: Richard Guo <guofenglinux(at)gmail(dot)com>
Reported-by: Richard Guo <guofenglinux(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAExHW5tHqEf3ASVqvFFcghYGPfpy7o3xnvhHwBGbJFMRH8KjNw@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0f7863afef67e462574fe5af6317e26a2f2d47fb
Modified Files
--------------
src/backend/optimizer/path/joinrels.c | 5 +++--
src/backend/optimizer/util/orclauses.c | 23 +++++------------------
2 files changed, 8 insertions(+), 20 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2024-03-25 11:11:27 | pgsql: Track last_inactive_time in pg_replication_slots. |
| Previous Message | Amit Langote | 2024-03-25 10:22:09 | Re: pgsql: Do not translate dummy SpecialJoinInfos for child joins |