| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Release PQconninfoOptions array in GetDbnameFromConnectionOption |
| Date: | 2024-03-24 16:31:55 |
| Message-ID: | E1roQlH-005RwL-Ag@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Release PQconninfoOptions array in GetDbnameFromConnectionOptions().
It wasn't getting freed in one code path, which Coverity identified as
a resource leak. It's probably of little consequence, but re-ordering
the code into the correct sequence is no more work than dismissing the
complaint. Minor oversight in commit a145f424d.
While here, improve the unreasonably clunky coding of
FindDbnameInConnParams: use of an output parameter is unnecessary
and prone to uninitialized-variable problems.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d37e0d0c50ee560fa2e7dc2a4dc904a885957985
Modified Files
--------------
src/bin/pg_basebackup/streamutil.c | 29 ++++++++++++++---------------
1 file changed, 14 insertions(+), 15 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-03-24 18:30:40 | pgsql: Allow more cases to pass the unsafe-use-of-new-enum-value restri |
| Previous Message | Peter Eisentraut | 2024-03-24 07:43:30 | pgsql: ci: freebsd repartition script didn't copy .git directory |