| From: | Amit Kapila <akapila(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix a random failure in 038_save_logical_slots_shutdown.pl. |
| Date: | 2024-03-13 03:14:39 |
| Message-ID: | E1rkF4h-003WNC-1R@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix a random failure in 038_save_logical_slots_shutdown.pl.
The test ensures that all the WAL on the publisher is sent to the
subscriber before shutdown by comparing the confirmed_flush_lsn of the
associated slot with the shutdown_checkpoint WAL location. But if the
shutdown_checkpoint location falls into a new page in the WAL then the
check won't work. So, ensure that the shutdown_checkpoint WAL record
doesn't fall into a new page.
Reported-by: Bharath Rupireddy
Author: Bharath Rupireddy
Reviewed-by: Vignesh C, Kuroda Hayato, Amit Kapila
Discussion: https://postgr.es/m/CALj2ACVLzH5CN-h9=S26mdRHPuJ9yDLUw70yh4JOiPw03WL0CQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0b84f5c419a300dc1b1a70cf63b9907208e52643
Modified Files
--------------
src/test/recovery/t/038_save_logical_slots_shutdown.pl | 10 ++++++++++
1 file changed, 10 insertions(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-03-13 05:20:50 | pgsql: Add tests for more row patterns with COPY FROM .. (ON_ERROR igno |
| Previous Message | Thomas Munro | 2024-03-13 02:01:29 | pgsql: ci: Use a RAM disk and more CPUs on FreeBSD. |