pgsql: Handle interleavings between CREATE DATABASE steps and base back

From: Noah Misch <noah(at)leadboat(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Handle interleavings between CREATE DATABASE steps and base back
Date: 2024-02-01 21:46:30
Message-ID: E1rVetC-004Dfa-LG@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Handle interleavings between CREATE DATABASE steps and base backup.

Restoring a base backup taken in the middle of CreateDirAndVersionFile()
or write_relmap_file() would lose the function's effects. The symptom
was absence of the database directory, PG_VERSION file, or
pg_filenode.map. If missing the directory, recovery would fail. Either
missing file would not fail recovery but would render the new database
unusable. Fix CreateDirAndVersionFile() with the transam/README "action
first and then write a WAL entry" strategy. That has a side benefit of
moving filesystem mutations out of a critical section, reducing the ways
to PANIC. Fix the write_relmap_file() call with a lock acquisition, so
it interacts with checkpoints like non-CREATE DATABASE calls do.
Back-patch to v15, where commit 9c08aea6a3090a396be334cc58c511edab05776a
introduced STRATEGY=WAL_LOG and made it the default.

Discussion: https://postgr.es/m/20240130195003.0a.nmisch@google.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d493bed28f7f6c77051bba3dde383e0ff78d3a19

Modified Files
--------------
src/backend/commands/dbcommands.c | 44 +++++++++++++++----------------------
src/backend/utils/cache/relmapper.c | 16 ++++++++++++--
2 files changed, 32 insertions(+), 28 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2024-02-02 11:20:45 pgsql: Allow Gather Merge in more cases for parallel DISTINCT
Previous Message Tom Lane 2024-02-01 20:58:10 pgsql: Update time zone data files to tzdata release 2024a.