pgsql: pgcrypto: Fix check for buffer size

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pgcrypto: Fix check for buffer size
Date: 2024-01-30 10:27:26
Message-ID: E1rUlKw-003pOa-Ja@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pgcrypto: Fix check for buffer size

The code copying the PGP block into the temp buffer failed to
account for the extra 2 bytes in the buffer which are needed
for the prefix. If the block was oversized, subsequent checks
of the prefix would have exceeded the buffer size. Since the
block sizes are hardcoded in the list of supported ciphers it
can be verified that there is no live bug here. Backpatch all
the way for consistency though, as this bug is old.

Author: Mikhail Gribkov <youzhick(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAMEv5_uWvcMCMdRFDsJLz2Q8g16HEa9xWyfrkr+FYMMFJhawOw@mail.gmail.com
Backpatch-through: v12

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f74b5c5bc67c3c1df799e5dd073a441984953b44

Modified Files
--------------
contrib/pgcrypto/pgp-decrypt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Daniel Gustafsson 2024-01-30 10:28:01 pgsql: pgcrypto: Fix check for buffer size
Previous Message Daniel Gustafsson 2024-01-30 10:27:15 pgsql: pgcrypto: Fix check for buffer size