From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Abort pgbench if script end is reached with an open pipeline |
Date: | 2024-01-22 16:50:37 |
Message-ID: | E1rRxVN-002bsi-0b@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Abort pgbench if script end is reached with an open pipeline
When a pipeline is opened with \startpipeline and not closed, pgbench
will either error on the next transaction with a "already in pipeline
mode" error or successfully end if this was the last transaction --
despite not sending anything that was piped in the pipeline.
Make it an error to reach end of script is reached while there's an
open pipeline.
Backpatch to 14, where pgbench got support for pipelines.
Author: Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>
Reported-by: Michael Paquier <michael(at)paquier(dot)xyz>
Discussion: https://postgr.es/m/Za4IObZkDjrO4TcS@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/49f7c6c44a5f6a7f7b39d140e490c9c627511893
Modified Files
--------------
src/bin/pgbench/pgbench.c | 15 +++++++++++++--
src/bin/pgbench/t/001_pgbench_with_server.pl | 28 ++++++++++++++++++++++++++++
2 files changed, 41 insertions(+), 2 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2024-01-22 19:01:56 | pgsql: Fix two memcpy() bugs in the new injection point code |
Previous Message | Alvaro Herrera | 2024-01-22 16:16:01 | pgsql: Test EXPLAIN (FORMAT JSON) ... XMLTABLE |