pgsql: Rework how logirep launchers are stopped during pg_upgrade

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Rework how logirep launchers are stopped during pg_upgrade
Date: 2024-01-11 23:27:02
Message-ID: E1rO4Ry-000ynn-Qd@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Rework how logirep launchers are stopped during pg_upgrade

This is a rework of 7021d3b17664, where we relied on forcing
max_logical_replication_workers to 0 in the postgres command. This
commit now prevents logical replication launchers to start using -b and
a backend-side check based on IsBinaryUpgrade, effective when upgrading
from 17 and newer versions.

This commit improves the comments explaining why this restriction is
necessary.

This discussion was on hold until we were sure how to add support for
subscribers in pg_upgrade, something now done thanks to 9a17be1e244a.

Reviewed-by: Álvaro Herrera, Amit Kapila, Tom Lane
Discussion: https://postgr.es/m/ZU2TeVkUg5qEi7Oy@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/08c3ad27eb5348d0cbffa843a3edb11534f9904a

Modified Files
--------------
src/backend/replication/logical/launcher.c | 9 ++++++++-
src/bin/pg_upgrade/server.c | 15 +++++----------
2 files changed, 13 insertions(+), 11 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Bharath Rupireddy 2024-01-12 01:58:26 Re: pgsql: Add support event triggers on authenticated login
Previous Message Peter Eisentraut 2024-01-11 21:26:07 pgsql: Fix some inconsistent whitespace in Perl file