| From: | Nathan Bossart <nathan(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Cross-check lists of predefined LWLocks. |
| Date: | 2024-01-09 17:06:07 |
| Message-ID: | E1rNFYF-000e29-UE@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Cross-check lists of predefined LWLocks.
Both lwlocknames.txt and wait_event_names.txt contain a list of all
the predefined LWLocks, i.e., those with predefined positions
within MainLWLockArray. It is easy to miss one or the other,
especially since the list in wait_event_names.txt omits the "Lock"
suffix from all the LWLock wait events. This commit adds a cross-
check of these lists to the script that generates lwlocknames.h.
If the lists do not match exactly, building will fail.
Suggested-by: Robert Haas
Reviewed-by: Robert Haas, Michael Paquier, Bertrand Drouvot
Discussion: https://postgr.es/m/20240102173120.GA1061678%40nathanxps13
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5b1b9bce84497ec71dbd6d5a969e8fc5aa22b4ef
Modified Files
--------------
src/backend/Makefile | 2 +-
src/backend/storage/lmgr/Makefile | 4 +-
src/backend/storage/lmgr/generate-lwlocknames.pl | 49 ++++++++++++++++++++++++
src/backend/utils/activity/wait_event_names.txt | 12 ++++++
src/include/storage/meson.build | 4 +-
5 files changed, 67 insertions(+), 4 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-01-09 17:35:57 | pgsql: Fix documentation for wal_summary_keep_time. |
| Previous Message | Joe Conway | 2024-01-09 14:17:22 | pgsql: Add new function, PQchangePassword(), to libpq |