| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Improve some error messages with invalid indexes for REINDEX CON |
| Date: | 2023-12-07 05:28:58 |
| Message-ID: | E1rB6wT-008yi7-UH@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Improve some error messages with invalid indexes for REINDEX CONCURRENTLY
An invalid index is skipped when doing REINDEX CONCURRENTLY at table
level, with INDEX_CORRUPTED used as errcode. This is confusing,
because an invalid index could exist after an interruption. The errcode
is switched to OBJECT_NOT_IN_PREREQUISITE_STATE instead, as per a
suggestion from Andres Freund.
While on it, the error messages are reworded, and a hint is added,
telling how to rebuild an invalid index in this case. This has been
suggested by Noah Misch.
Discussion: https://postgr.es/m/20231118230958.4fm3fhk4ypshxopa@awork3.anarazel.de
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d43bd090a8fee81fe88eb1e9e15e30d30ee130ed
Modified Files
--------------
src/backend/commands/indexcmds.c | 14 ++++++++------
src/test/regress/expected/create_index.out | 3 ++-
2 files changed, 10 insertions(+), 7 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2023-12-07 08:29:04 | pgsql: Verify that attribute counts match in ExecCopySlot |
| Previous Message | Amit Kapila | 2023-12-07 03:24:39 | pgsql: Fix issues in binary_upgrade_logical_slot_has_caught_up(). |