| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: amcheck: Distinguish interrupted page deletion from corruption. |
| Date: | 2023-10-30 21:47:09 |
| Message-ID: | E1qxa6G-003AIX-Nf@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
amcheck: Distinguish interrupted page deletion from corruption.
This prevents false-positive reports about "the first child of leftmost
target page is not leftmost of its level", "block %u is not leftmost"
and "left link/right link pair". They appeared if amcheck ran before
VACUUM cleaned things, after a cluster exited recovery between the
first-stage and second-stage WAL records of a deletion. Back-patch to
v11 (all supported versions).
Reviewed by Peter Geoghegan.
Discussion: https://postgr.es/m/20231005025232.c7.nmisch@google.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6ec9e9975eff5260651d84ed8bcfd8ecb08e5fbb
Modified Files
--------------
contrib/amcheck/Makefile | 1 +
contrib/amcheck/meson.build | 1 +
contrib/amcheck/t/005_pitr.pl | 82 ++++++++++++++++++++++++++++++++++++++++
contrib/amcheck/verify_nbtree.c | 83 +++++++++++++++++++++++++++++++++++++++--
4 files changed, 163 insertions(+), 4 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-10-30 22:36:34 | Re: pgsql: Teach contrib/amcheck to check the unique constraint violation |
| Previous Message | Bruce Momjian | 2023-10-30 18:53:00 | pgsql: pgindent run to fix commits de64268561 and 5ae2087202a |