pgsql: Clean up some pg_dump tests

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Clean up some pg_dump tests
Date: 2023-10-18 06:13:04
Message-ID: E1qsznj-0017Fj-QM@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Clean up some pg_dump tests

1) Remove useless entries from "unlike" lists. Runs that are not
listed in "like" don't need to be excluded in "unlike".

2) Ensure there is always a "like" list, even if it is empty. This
makes the test more self-documenting.

3) Use predefined lists such as %full_runs where appropriate, instead
of listing all runs separately.

Also add code that checks 1 and 2 automatically and dies with an error
for violations.

Reviewed-by: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Discussion: https://www.postgresql.org/message-id/flat/1f8cb371-e84e-434e-0367-6b716fb16fa1(at)eisentraut(dot)org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/41a284411e09a3c0a401cd5ab81fbf1802fe8021

Modified Files
--------------
src/bin/pg_dump/t/002_pg_dump.pl | 78 +++++++++++-----------------------------
1 file changed, 21 insertions(+), 57 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2023-10-18 09:24:18 pgsql: pg_upgrade: Fix test name in 002_pg_upgrade.pl
Previous Message Michael Paquier 2023-10-18 05:55:09 pgsql: Count write times when extending relation files for shared buffe