pgsql: worker_spi: Fix test failure with BGWORKER_BYPASS_ALLOWCONN

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: worker_spi: Fix test failure with BGWORKER_BYPASS_ALLOWCONN
Date: 2023-10-06 01:03:25
Message-ID: E1qoZFU-000FxV-Fz@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

worker_spi: Fix test failure with BGWORKER_BYPASS_ALLOWCONN

A bgworker can spawn parallel workers of its own when executing queries,
and if the worker uses BGWORKER_BYPASS_ALLOWCONN while the database it
is connected to does not allow connections, a parallel worker would fail
to startup. In the case of this module, the step checking for the
presence of the schema to create was spawning a worker, failing the last
test introduced by 991bb0f9653c.

This issue could be reproduced with debug_parallel_query = 'regress',
for example.

Per buildfarm member crake.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fd4d93d269c02081958e4c0c214f1d82186e5689

Modified Files
--------------
src/test/modules/worker_spi/worker_spi.c | 9 +++++++++
1 file changed, 9 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2023-10-06 07:27:15 pgsql: Fix crash on syslogger startup
Previous Message Michael Paquier 2023-10-06 00:02:44 pgsql: worker_spi: Add tests for BGWORKER_BYPASS_ALLOWCONN