From: | Robert Haas <rhaas(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: In basebackup.c, refactor to create verify_page_checksum. |
Date: | 2023-10-03 14:47:50 |
Message-ID: | E1qnggg-007JdY-RY@gemulon.postgresql.org |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
In basebackup.c, refactor to create verify_page_checksum.
If checksum verification fails for a particular page, we reread the
page and try one more time. The code that does this somewhat complex
and difficult to follow. Move some of the logic into a new function
and rearrange the code a bit to try to make it clearer. This way,
we don't need the block_retry Boolean, a couple of other variables
move from sendFile() into the new function, and some code is now less
deeply indented.
Patch by me, reviewed by David Steele.
Discussion: http://postgr.es/m/CA+TgmoYt5jXH4U6cu1dm9Oe2FTn1aae6hBNhZzJJjyjbE_zYig@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/053183138a7a11408d6faa9281001ff7b1ffee2e
Modified Files
--------------
src/backend/backup/basebackup.c | 188 ++++++++++++++++++++++------------------
1 file changed, 104 insertions(+), 84 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2023-10-03 15:01:18 | pgsql: In basebackup.c, refactor to create read_file_data_into_buffer. |
Previous Message | Michael Paquier | 2023-10-03 06:37:54 | pgsql: Avoid memory size overflow when allocating backend activity buff |