| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Only evaluate default values as required when doing COPY FROM |
| Date: | 2023-10-01 14:25:59 |
| Message-ID: | E1qmxOR-006zZm-Gu@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Only evaluate default values as required when doing COPY FROM
Commit 9f8377f7a2 was a little too eager in fetching default values.
Normally this would not matter, but if the default value is not valid
for the type (e.g. a varchar that's too long) it caused an unnecessary
error.
Complaint and fix from Laurenz Albe
Backpatch to release 16.
Discussion: https://postgr.es/m/75a7b7483aeb331aa017328d606d568fc715b90d.camel@cybertec.at
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/276393f53efbf08f72190221e9c1ef2a28e7fc66
Modified Files
--------------
src/backend/commands/copyfrom.c | 9 ++++++++-
src/test/regress/expected/copy.out | 17 +++++++++++++++++
src/test/regress/sql/copy.sql | 15 +++++++++++++++
3 files changed, 40 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-10-01 16:09:39 | pgsql: In COPY FROM, fail cleanly when unsupported encoding conversion |
| Previous Message | Andres Freund | 2023-09-30 19:36:23 | pgsql: meson: macos: Correct -exported_symbols_list syntax for Sonoma c |