pgsql: unaccent: Tweak value of PYTHON when building without Python sup

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: unaccent: Tweak value of PYTHON when building without Python sup
Date: 2023-09-27 05:42:17
Message-ID: E1qlNJR-006DsS-Qk@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

unaccent: Tweak value of PYTHON when building without Python support

As coded, the module's Makefile would fail to set a value for PYTHON as
it checked if the variable is defined. When compiling without
--with-python, PYTHON is defined and set to an empty value, so the
existing check is not able to do its work.

This commit switches the rule to check if the value is empty rather than
defined, allowing the generation of unaccent.rules even if --with-python
is not used as long as "python" exists. BISON and FLEX do the same in
pgxs.mk, for instance.

Thinko in f85a485f89e2.

Author: Japin Li
Discussion: https://postgr.es/m/MEYP282MB1669F86C0DC7B4DC48489CB0B6C3A@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
Backpatch-through: 13

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a64b8b03556a19674e2a8723efb9f940babc3491

Modified Files
--------------
contrib/unaccent/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2023-09-27 09:15:13 pgsql: Fix the misuse of origin filter across multiple pg_logical_slot_
Previous Message Tom Lane 2023-09-27 01:06:47 pgsql: Stop using "-multiply_defined suppress" on macOS.