pgsql: Allow extracting fields from a ROW() expression in more cases.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Allow extracting fields from a ROW() expression in more cases.
Date: 2023-09-15 21:02:06
Message-ID: E1qhFx0-0042tp-K4@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Allow extracting fields from a ROW() expression in more cases.

Teach get_expr_result_type() to manufacture a tuple descriptor directly
from a RowExpr node. If the RowExpr has type RECORD, this is the only
way to get a tupdesc for its result, since even if the rowtype has been
blessed, we don't have its typmod available at this point. (If the
RowExpr has some named composite type, we continue to let the existing
code handle it, since the RowExpr might well not have the correct column
names embedded in it.)

This fixes assorted corner cases illustrated by the added regression
tests.

This is a back-patch of the v13-era commit 8b7a0f1d1 into previous
branches. At the time I'd judged it not important enough to back-patch,
but the upcoming fix for bug #18077 includes a test case that depends
on this working correctly; and 8b7a0f1d1 has now aged long enough to
have good confidence that it won't break anything.

Discussion: https://postgr.es/m/10872.1572202006@sss.pgh.pa.us
Discussion: https://postgr.es/m/3607145.1694803130@sss.pgh.pa.us

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2f02d4a2b9cbf4991a73e15d4674d8cfa905bb61

Modified Files
--------------
src/backend/utils/fmgr/funcapi.c | 32 ++++++++++++++++++++++++++++
src/test/regress/expected/rowtypes.out | 39 ++++++++++++++++++++++++++++++++++
src/test/regress/sql/rowtypes.sql | 9 ++++++++
3 files changed, 80 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-09-15 21:02:07 pgsql: Fix get_expr_result_type() to find field names for RECORD Consts
Previous Message Daniel Gustafsson 2023-09-15 17:09:45 pgsql: Rename variable for code clarity