pgsql: Eliminate fixed token-length limit in hba.c.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Eliminate fixed token-length limit in hba.c.
Date: 2023-07-27 16:08:13
Message-ID: E1qP3XA-001biP-37@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Eliminate fixed token-length limit in hba.c.

Historically, hba.c limited tokens in the authentication configuration
files (pg_hba.conf and pg_ident.conf) to less than 256 bytes. We have
seen a few reports of this limit causing problems; notably, for
moderately-complex LDAP configurations. Let's get rid of the fixed
limit by using a StringInfo instead of a fixed-size buffer.
This actually takes less code than before, since we can get rid of
a nontrivial error recovery stanza. It's doubtless a hair slower,
but parsing the content of the HBA files should in no way be
performance-critical.

Although this is a pretty straightforward patch, it doesn't seem
worth the risk to back-patch given the small number of complaints
to date. In released branches, we'll just raise MAX_TOKEN to
ameliorate the problem.

Discussion: https://postgr.es/m/1588937.1690221208@sss.pgh.pa.us

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/de3f0e3fe0e7d44620111c5723504a3a6e8c046e

Modified Files
--------------
src/backend/libpq/hba.c | 74 +++++++++++++++++--------------------------------
1 file changed, 26 insertions(+), 48 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Etsuro Fujita 2023-07-28 06:51:58 pgsql: Disallow replacing joins with scans in problematic cases.
Previous Message Michael Paquier 2023-07-27 04:30:35 pgsql: worker_spi: Switch to TAP tests