pgsql: Revert the commits related to allowing page lock to conflict amo

From: Amit Kapila <akapila(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Revert the commits related to allowing page lock to conflict amo
Date: 2023-07-06 03:34:51
Message-ID: E1qHFlb-0028Bk-81@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Revert the commits related to allowing page lock to conflict among parallel group members.

This commit reverts the work done by commits 3ba59ccc89 and 72e78d831a.
Those commits were incorrect in asserting that we never acquire any other
heavy-weight lock after acquring page lock other than relation extension
lock. We can acquire a lock on catalogs while doing catalog look up after
acquring page lock.

This won't impact any existing feature but we need to think some other way
to achieve this before parallelizing other write operations or even
improving the parallelism in vacuum (like allowing multiple workers
for an index).

Reported-by: Jaime Casanova
Author: Amit Kapila
Backpatch-through: 13
Discussion: https://postgr.es/m/CAJKUy5jffnRKNvRHKQ0LynRb0RJC-o4P8Ku3x9vGAVLwDBWumQ@mail.gmail.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cf3e29851278e18b7b4997cd0bd90edb372c69da

Modified Files
--------------
src/backend/optimizer/plan/planner.c | 12 +++++++-----
src/backend/storage/lmgr/README | 34 +++++++++++++---------------------
src/backend/storage/lmgr/deadlock.c | 9 ++++-----
src/backend/storage/lmgr/lock.c | 32 ++++----------------------------
src/backend/storage/lmgr/proc.c | 12 ++++++------
5 files changed, 34 insertions(+), 65 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2023-07-06 04:41:13 pgsql: Add newline at the end of header generated by generate-wait_even
Previous Message Michael Paquier 2023-07-05 23:18:49 pgsql: Handle \v as a whitespace character in parsers