pgsql: Remove incidental md5() function uses from several tests

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove incidental md5() function uses from several tests
Date: 2023-07-04 12:45:08
Message-ID: E1qGfP2-001s3f-Kp@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove incidental md5() function uses from several tests

This removes md5() function calls from these test suites:

- bloom
- test_decoding
- isolation
- recovery
- subscription

This covers all remaining test suites where md5() calls were just used
to generate some random data and can be replaced by appropriately
adapted sha256() calls. This will eventually allow these tests to
pass in OpenSSL FIPS mode (which does not allow MD5 use). See also
208bf364a9. Unlike for the main regression tests, I didn't write a
fipshash() wrapper here, because that would have been too repetitive
and wouldn't really save much here. In some cases it was easier to
remove one layer of indirection by changing column types from text to
bytea.

Reviewed-by: Daniel Gustafsson <daniel(at)yesql(dot)se>
Discussion: https://www.postgresql.org/message-id/flat/f9b480b5-e473-d2d1-223a-4b9db30a229a(at)eisentraut(dot)org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/657f5f223e8fd9aa12d8d9fc473faecc267b9b7a

Modified Files
--------------
contrib/bloom/expected/bloom.out | 32 ++++++++++----------
contrib/bloom/sql/bloom.sql | 8 ++---
contrib/bloom/t/001_wal.pl | 4 +--
.../test_decoding/expected/concurrent_stream.out | 6 ++--
contrib/test_decoding/specs/concurrent_stream.spec | 8 ++---
.../specs/insert-conflict-specconflict.spec | 2 +-
src/test/recovery/t/015_promotion_pages.pl | 4 +--
src/test/recovery/t/026_overwrite_contrecord.pl | 2 +-
src/test/subscription/t/008_diff_schema.pl | 4 +--
src/test/subscription/t/015_stream.pl | 16 +++++-----
src/test/subscription/t/016_stream_subxact.pl | 24 +++++++--------
src/test/subscription/t/017_stream_ddl.pl | 18 ++++++------
.../subscription/t/018_stream_subxact_abort.pl | 34 +++++++++++-----------
.../subscription/t/019_stream_subxact_ddl_abort.pl | 14 ++++-----
src/test/subscription/t/022_twophase_cascade.pl | 14 ++++-----
src/test/subscription/t/023_twophase_stream.pl | 24 +++++++--------
src/test/subscription/t/029_on_error.pl | 8 ++---
17 files changed, 111 insertions(+), 111 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2023-07-04 15:31:31 pgsql: Ensure that creation of an empty relfile is fsync'd at checkpoin
Previous Message David Rowley 2023-07-04 11:09:09 pgsql: Allow Incremental Sorts on GiST and SP-GiST indexes