pgsql: Move return statements out of PG_TRY blocks.

From: Nathan Bossart <nathan(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Move return statements out of PG_TRY blocks.
Date: 2023-05-04 23:27:54
Message-ID: E1puiMb-000W7V-QB@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Move return statements out of PG_TRY blocks.

If we exit a PG_TRY block early via "continue", "break", "goto", or
"return", we'll skip unwinding its exception stack. This change
moves a couple of such "return" statements in PL/Python out of
PG_TRY blocks. This was introduced in d0aa965c0a and affects all
supported versions.

We might also be able to add compile-time checks to prevent
recurrence, but that is left as a future exercise.

Reported-by: Mikhail Gribkov, Xing Guo
Author: Xing Guo
Reviewed-by: Michael Paquier, Andres Freund, Tom Lane
Discussion: https://postgr.es/m/CAMEv5_v5Y%2B-D%3DCO1%2Bqoe16sAmgC4sbbQjz%2BUtcHmB6zcgS%2B5Ew%40mail.gmail.com
Discussion: https://postgr.es/m/CACpMh%2BCMsGMRKFzFMm3bYTzQmMU5nfEEoEDU2apJcc4hid36AQ%40mail.gmail.com
Backpatch-through: 11 (all supported versions)

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/800531846ef7da5f4a234fbb6fd65a91c7ecb33f

Modified Files
--------------
src/pl/plpython/plpy_exec.c | 54 ++++++++++++++++++++++++++++++---------------
1 file changed, 36 insertions(+), 18 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2023-05-04 23:54:13 Re: issue with meson builds on msys2
Previous Message Alvaro Herrera 2023-05-04 17:58:26 pgsql: Fix ExecCheckPermissions call in RI_Initial_Check