pgsql: Add --buffer-usage-limit option to vacuumdb

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add --buffer-usage-limit option to vacuumdb
Date: 2023-04-07 00:47:29
Message-ID: E1pkaGF-001lkT-Q7@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add --buffer-usage-limit option to vacuumdb

1cbbee033 added BUFFER_USAGE_LIMIT to the VACUUM and ANALYZE commands, so
here we permit that option to be specified in vacuumdb.

In passing, adjust the documents for vacuum_buffer_usage_limit and the
BUFFER_USAGE_LIMIT VACUUM option to mention "kB" rather than "KB". Do the
same for the ERROR message in ExecVacuum() and
check_vacuum_buffer_usage_limit(). Without that we might tell a user that
the valid minimum value is 128 KB only to reject that because we accept
only "kB" and not "KB".

Also, add a small reminder comment in vacuum.h to try to trigger the
memory of anyone adding new fields to VacuumParams that they might want to
consider if vacuumdb needs to grow a new option too.

Author: Melanie Plageman
Reviewed-by: Justin Pryzby
Reviewed-by: David Rowley
Discussion: https://postgr.es/m/ZAzTg3iEnubscvbf@telsasoft.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ae78cae3be627213528f2e08eb976d6906d754de

Modified Files
--------------
doc/src/sgml/config.sgml | 4 ++--
doc/src/sgml/ref/vacuumdb.sgml | 13 +++++++++++++
src/backend/commands/vacuum.c | 4 ++--
src/bin/scripts/vacuumdb.c | 26 ++++++++++++++++++++++++++
src/include/commands/vacuum.h | 3 +++
src/test/regress/expected/vacuum.out | 4 ++--
6 files changed, 48 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2023-04-07 01:03:02 pgsql: Use ExtendBufferedRelTo() in XLogReadBufferExtended()
Previous Message Andres Freund 2023-04-07 00:01:41 pgsql: hio: Use ExtendBufferedRelBy() to extend tables more efficiently