pgsql: Don't leak descriptors into subprograms.

From: Thomas Munro <tmunro(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Don't leak descriptors into subprograms.
Date: 2023-03-02 21:56:31
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Don't leak descriptors into subprograms.

Open long-lived data and WAL file descriptors with O_CLOEXEC. This flag
was introduced by SUSv4 (POSIX.1-2008), and by now all of our target
Unix systems have it. Our open() implementation for Windows already had
that behavior, so provide a dummy O_CLOEXEC flag on that platform.

For now, callers of open() and the "thin" wrappers in fd.c that deal in
raw descriptors need to pass in O_CLOEXEC explicitly if desired. This
commit does that for WAL files, and automatically for everything
accessed via VFDs including SMgrRelation and BufFile. (With more
discussion we might decide to turn it on automatically for the thin
open()-wrappers too to avoid risk of missing places that need it, but
these are typically used for short-lived descriptors where we don't
expect to fork/exec, and it's remotely possible that extensions could be
using these APIs and passing descriptors to subprograms deliberately, so
that hasn't been done here.)

Do the same for sockets and the postmaster pipe with FD_CLOEXEC. (Later
commits might use modern interfaces to remove these extra fcntl() calls
and more where possible, but we'll need them as a fallback for a couple
of systems, so do it that way in this initial commit.)

With this change, subprograms executed for archiving, copying etc will
no longer have access to the server's descriptors, other than the ones
that we decide to pass down.

Reviewed-by: Andres Freund <andres(at)anarazel(dot)de> (earlier version)



Modified Files
src/backend/access/transam/xlog.c | 9 ++++++---
src/backend/libpq/pqcomm.c | 7 +++++++
src/backend/storage/file/fd.c | 8 ++++++++
src/backend/utils/init/miscinit.c | 8 ++++++++
src/include/port/win32_port.h | 7 +++++++
5 files changed, 36 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-03-02 22:15:19 pgsql: Show "internal name" not "source code" in psql's \df+ command.
Previous Message Tom Lane 2023-03-02 17:01:57 pgsql: Remove local optimizations of empty Bitmapsets into null pointer