From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Don't repeatedly register cache callbacks in pgoutput plugin. |
Date: | 2023-02-23 20:40:59 |
Message-ID: | E1pVIOg-000MOr-NM@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Don't repeatedly register cache callbacks in pgoutput plugin.
Multiple cycles of starting up and shutting down the plugin within a
single session would eventually lead to "out of relcache_callback_list
slots", because pgoutput_startup blindly re-registered its cache
callbacks each time. Fix it to register them only once, as all other
users of cache callbacks already take care to do.
This has been broken all along, so back-patch to all supported branches.
Shi Yu
Discussion: https://postgr.es/m/OSZPR01MB631004A78D743D68921FFAD3FDA79@OSZPR01MB6310.jpnprd01.prod.outlook.com
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/0f78df719a90e3f992304f63b146b178e676bed2
Modified Files
--------------
src/backend/replication/pgoutput/pgoutput.c | 24 +++++++++++++++++++++---
1 file changed, 21 insertions(+), 3 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2023-02-24 00:20:29 | Re: pgsql: Refactor to add pg_strcoll(), pg_strxfrm(), and variants. |
Previous Message | Tomas Vondra | 2023-02-23 20:21:39 | pgsql: Add LZ4 compression to pg_dump |