pgsql: remove_rel_from_query() must clean up PlaceHolderVar.phrels fiel

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: remove_rel_from_query() must clean up PlaceHolderVar.phrels fiel
Date: 2023-02-08 19:45:48
Message-ID: E1pPqO3-0007o1-Qt@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

remove_rel_from_query() must clean up PlaceHolderVar.phrels fields.

While we got away with this sloppiness before, it's not okay now
that fee7b77b9 caused build_joinrel_tlist() to make use of phrels.
Per report from Robins Tharakan.

Richard Guo (some cosmetic tweaks by me)

Discussion: https://postgr.es/m/CAMbWs4_ngw9sKxpTE8hqk=-ooVX_CQP3DarA4HzkRMz_JKpTrA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/798c0176342150c8fe1404b0007b299db2e73ce0

Modified Files
--------------
src/backend/optimizer/plan/analyzejoins.c | 17 ++++++++++-------
src/test/regress/expected/join.out | 16 ++++++++++++++++
src/test/regress/sql/join.sql | 7 +++++++
3 files changed, 33 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2023-02-08 21:57:55 pgsql: Backpatch OpenSSL 3.0.0 compatibility in tests
Previous Message Michael Paquier 2023-02-08 07:57:23 pgsql: Remove SQL regression tests for GUCs related to NO_SHOW_ALL