pgsql: Fix LATERAL join test in test memoize.sql

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix LATERAL join test in test memoize.sql
Date: 2023-01-23 23:30:50
Message-ID: E1pK6H4-0058ux-8l@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix LATERAL join test in test memoize.sql

The test in question was meant to be testing Memoize to ensure it worked
correctly when the inner side of the join contained lateral vars, however,
nothing in the lateral subquery stopped it from being pulled up into the
main query, so the planner did that, and that meant no more lateral vars.

Here we add a simple ORDER BY to stop the planner from being able to
pullup the lateral subquery.

Author: Richard Guo
Discussion: https://postgr.es/m/CAMbWs4_LHJaN4L-tXpKMiPFnsCJWU1P8Xh59o0W7AA6UN99=cQ@mail.gmail.com
Backpatch-through: 14, where Memoize was added.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b762fed6481e722a022ac2bea02151e080c31fa6

Modified Files
--------------
src/test/regress/expected/memoize.out | 8 +++++---
src/test/regress/sql/memoize.sql | 6 ++++--
2 files changed, 9 insertions(+), 5 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-01-23 23:37:41 Re: pgsql: Fix LATERAL join test in test memoize.sql
Previous Message David Rowley 2023-01-23 23:30:23 pgsql: Fix LATERAL join test in test memoize.sql