pgsql: Remove some dead code in selfuncs.c

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove some dead code in selfuncs.c
Date: 2023-01-19 12:03:51
Message-ID: E1pITe3-004ReV-5B@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove some dead code in selfuncs.c

RelOptInfo.userid is the same for all relations in a given inheritance
tree, so the code in examine_variable() and example_simple_variable()
that repeats the ACL checks on the root parent rel instead of a given
leaf child relations need not recompute userid too.

Author: Amit Langote <amitlangote09(at)gmail(dot)com>
Reported-by: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Discussion: https://postgr.es/m/20221210201753.GA27893@telsasoft.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/438e6b7240905c8055f9e221187f2ac818876169

Modified Files
--------------
src/backend/optimizer/util/relnode.c | 1 -
src/backend/utils/adt/selfuncs.c | 42 ++++++++++++++----------------------
2 files changed, 16 insertions(+), 27 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-01-19 15:45:34 Re: pgsql: Remove some dead code in selfuncs.c
Previous Message Peter Eisentraut 2023-01-19 08:52:09 pgsql: Constify proclist.h