pgsql: Avoid O(N^2) cost when pulling up lots of UNION ALL subqueries.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Avoid O(N^2) cost when pulling up lots of UNION ALL subqueries.
Date: 2022-12-22 16:02:10
Message-ID: E1p8O1J-004tIq-4V@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid O(N^2) cost when pulling up lots of UNION ALL subqueries.

perform_pullup_replace_vars() knows how to scan the whole parent
query tree when we are replacing Vars during a subquery flattening
operation. However, for the specific case of flattening a
UNION ALL leaf query, that's mostly wasted work: the only place
where relevant Vars could exist is in the AppendRelInfo that we
just made for this leaf. Teaching perform_pullup_replace_vars()
to just deal with that and exit is worthwhile because, if we have
N such subqueries to pull up, we were spending O(N^2) work uselessly
mutating the AppendRelInfos for all the other subqueries.

While we're at it, avoid calling substitute_phv_relids if there are no
PlaceHolderVars, and remove an obsolete check of parse->hasSubLinks.

Andrey Lepikhov and Tom Lane

Discussion: https://postgr.es/m/703c09a2-08f3-d2ec-b33d-dbecd62428b8@postgrespro.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e42e312430279dcd8947846fdfeb4885e3754eac

Modified Files
--------------
src/backend/optimizer/prep/prepjointree.c | 55 ++++++++++++++++++++-----------
1 file changed, 35 insertions(+), 20 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2022-12-22 17:39:11 pgsql: Refactor how VACUUM passes around its XID cutoffs.
Previous Message Tom Lane 2022-12-22 15:35:24 pgsql: Add some recursion and looping defenses in prepjointree.c.