pgsql: Reject missing database name in pg_regress and cohorts.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Reject missing database name in pg_regress and cohorts.
Date: 2022-11-30 18:01:53
Message-ID: E1p0RP6-001SbZ-JE@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Reject missing database name in pg_regress and cohorts.

Writing "pg_regress --dbname= ..." led to a crash, because
we weren't expecting there to be no database name supplied.
It doesn't seem like a great idea to run regression tests
in whatever is the user's default database; so rather than
supporting this case let's explicitly reject it.

Per report from Xing Guo. Back-patch to all supported
branches.

Discussion: https://postgr.es/m/CACpMh+A8cRvtvtOWVAZsCM1DU81GK4DL26R83y6ugZ1osV=ifA@mail.gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ae9939020dda40af579678489b11ef20fe3cca05

Modified Files
--------------
src/test/regress/pg_regress.c | 11 +++++++++++
1 file changed, 11 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-11-30 22:35:01 Re: pgsql: Revoke PUBLIC CREATE from public schema, now owned by pg_databas
Previous Message Robert Haas 2022-11-30 15:44:12 Re: pgsql: Revoke PUBLIC CREATE from public schema, now owned by pg_databas