| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Revert "Prevent instability in contrib/pageinspect's regression |
| Date: | 2022-11-21 20:40:47 |
| Message-ID: | E1oxDaw-000GEy-6g@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Revert "Prevent instability in contrib/pageinspect's regression test."
This reverts commit 5cda142bb9d2bd7e7ed1c22ae89afe58abfa8d7b
(in v14 only).
It turns out that that fails under force_parallel_mode = regress,
because pageinspect's disk-access functions are marked parallel
safe, which they are not if you try to use them on a temp table.
The cost of fixing that pre-v15 seems to exceed the value of
making this test case fully stable, so we will just leave things
as-is in v14.
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/47a22dc2cb89aca2e54c9cf9fe2da4a5e8ba4cb4
Modified Files
--------------
contrib/pageinspect/expected/page.out | 3 +--
contrib/pageinspect/sql/page.sql | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-11-21 22:01:02 | pgsql: Add workaround to make ubsan and ps_status.c compatible |
| Previous Message | Tom Lane | 2022-11-21 20:37:26 | pgsql: Mark pageinspect's disk-accessing functions as parallel restrict |