From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Postpone calls of unsafe server-side functions in pg_dump. |
Date: | 2022-11-19 17:00:52 |
Message-ID: | E1owRD2-000tbD-15@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Postpone calls of unsafe server-side functions in pg_dump.
Avoid calling pg_get_partkeydef(), pg_get_expr(relpartbound),
and regtypeout until we have lock on the relevant tables.
The existing coding is at serious risk of failure if there
are any concurrent DROP TABLE commands going on --- including
drops of other sessions' temp tables.
Back-patch of commit e3fcbbd62. That's been in v15/HEAD long enough
to have some confidence about it, so now let's fix the problem in
older branches.
Original patch by me; thanks to Gilles Darold for back-patching
legwork.
Discussion: https://postgr.es/m/2273648.1634764485@sss.pgh.pa.us
Discussion: https://postgr.es/m/7d7eb6128f40401d81b3b7a898b6b4de@W2012-02.nidsa.loc
Discussion: https://postgr.es/m/45c93d57-9973-248e-d2df-e02ca9af48d4@darold.net
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/55f30e6c7640c80fbb7be90fad668ee4bffa0e97
Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 146 +++++++++++++++++++++++++---------------------
src/bin/pg_dump/pg_dump.h | 4 +-
2 files changed, 79 insertions(+), 71 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2022-11-19 18:09:32 | pgsql: Doc: sync src/tutorial/basics.source with SGML documentation. |
Previous Message | Robert Haas | 2022-11-18 21:18:44 | pgsql: Fix typos and bump catversion. |