From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: windows: Adjust FD_SETSIZE via commandline define |
Date: | 2022-10-06 20:10:35 |
Message-ID: | E1ogXCU-001Cth-Hq@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
windows: Adjust FD_SETSIZE via commandline define
When using precompiled headers, we cannot pre-define macros for the system
headers from within .c files, as headers are already processed before
the #define in the C file is reached. But we can pre-define using
-DFD_SETSIZE, as long as that's also used when building the precompiled header.
A few files #define FD_SETSIZE 1024 on windows, as the default is only 64. I
am hesitant to change FD_SETSIZE globally on windows, due to
src/backend/port/win32/socket.c using it to size on-stack arrays. Instead add
-DFD_SETSIZE=1024 when building the specific targets needing it.
We likely should move away from using select() in those places, but that's a
larger change.
Reviewed-by: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Reviewed-by: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Reviewed-by: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/20221005190829.lda7ttalh4mzrvf4@awork3.anarazel.de
Discussion: https://postgr.es/m/CA+hUKG+50eOUbN++ocDc0Qnp9Pvmou23DSXu=ZA6fepOcftKqA@mail.gmail.com
Discussion: https://postgr.es/m/20190826054000.GE7005%40paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4289263cf263ba36e474728f4a02ceb086903f81
Modified Files
--------------
src/bin/pgbench/Makefile | 2 ++
src/bin/pgbench/meson.build | 1 +
src/bin/pgbench/pgbench.c | 4 ++--
src/fe_utils/Makefile | 4 ++++
src/fe_utils/meson.build | 1 +
src/fe_utils/parallel_slot.c | 4 ++--
src/tools/msvc/Mkvcbuild.pm | 27 +++++++++++++++++++--------
7 files changed, 31 insertions(+), 12 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2022-10-07 00:15:38 | pgsql: Fix final warnings produced by -Wshadow=compatible-local |
Previous Message | Tom Lane | 2022-10-06 17:35:38 | pgsql: Remove uses of MemoryContextContains in nodeAgg.c and nodeWindow |